Rewrite from proc-macro to build.rs #15
Open
+350
−345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses a proc-macro. This macro is not expanded in incremental builds. This causes changes in the static asset directory to not show up in the binary.
This proposed change drops the
load_assets!
macro and introduces a build script for the memory-serve crate. The build script takes an environment variable to load assets from. Any changes in the path defined byASSET_DIR
or changes to the variable itself will trigger a rerun and will load fresh assets.Note that this will be a breaking change:
Becomes:
And the
ASSET_DIR
environment variable will be required.This PR also ships some improvements to logging and improves build performance.